Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest AppImage download without GitHub account #605

Closed
HybridDog opened this issue Feb 22, 2024 · 2 comments · Fixed by #627
Closed

Latest AppImage download without GitHub account #605

HybridDog opened this issue Feb 22, 2024 · 2 comments · Fixed by #627
Labels

Comments

@HybridDog
Copy link

Describe the bug

The Readme explains a way to download the latest AppImage from the build jobs, but it does not work unless the reader is registered and logged in at GitHub, which is not mentioned.

Head over to our list of AppImage build jobs. When you click on a job, you'll see a page with an "Artifacts" section that contains an "appimage" binary you can then download.

To Reproduce
Steps to reproduce the behavior:

  1. Log out from GitHub
  2. Go to the mentioned link
  3. Click on the first "workflow run result"
  4. Scroll down to "Artifacts" and click on "appimage" next to the wireframe cube icon
  5. Observe how "appimage" is not a link but only text which can be marked

Expected behavior
The Readme could mention that downloading the build artifact requires a GitHub account or explain another way to download it.

Screenshots
2024-02-22-110536_990x373_scrot

Version Info (please complete the following information):

  • Linux Kernel version: not applicable
  • perf version: not applicable
  • hotspot version (appimage? selfcompiled?): master
  • if self-compiled hotspot, what version of elfutils: not applicable

Additional context
Downloading the older AppImage from the releases webpage works without GitHub account.

@HybridDog HybridDog added the bug label Feb 22, 2024
@GitMensch
Copy link
Contributor

There is no reasonable way to provide the Appimage on each CI build outside of the CI artifacts (which is needed for the download) - but it would definitely be useful to update the CI image on the release page from time to time, kind of "stable appimage" (which may be a new release).

As I personally see some issues [already worked on] that break the Disassembly view, I'd suggest to do that afterwards.

Another option is to run a nightly/weekly workflow to update the release as pointed out by @Kagami

- name: Release nightly
  uses: softprops/action-gh-release@v1
  with:
    prerelease: true
    name: nightly
    tag_name: nightly
    files: file.txt
    fail_on_unmatched_files: true

And instruct your users to download from https://github.com/OWNER/REPO/releases/download/nightly/file.txt Example here.

That file.txt will be updated on every commit, keeping single pre-release release without cluttering with other releases and latest stable release.

As a bonus it won't disappear if you don't commit for 90 days (as with artifacts).

With a similar example workflow on: https://github.com/kernelkit/infix/blob/main/.github/workflows/build.yml

@milianw
Copy link
Member

milianw commented Apr 25, 2024

we finally have a new stable release (https://github.com/KDAB/hotspot/releases/tag/v1.5.0). I would really like to see someone work on automated regular public continuous releases. I think @lievenhey is already looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants