-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cxx-qt-gen: support for marking signals in the base class #415
Conversation
Currently this uses #[cxx_qt::signals(MyObject)]
enum Signal {
#[existing_cxx_name="dataChanged"]
DataChanged
} But maybe instead the #[cxx_qt::signals(MyObject)]
enum Signal {
#[cxx_name="dataChanged"]
#[inherit]
DataChanged
} If you just use |
72d91a7
to
46ee6fd
Compare
Changed :-) |
46ee6fd
to
48dcc52
Compare
48dcc52
to
ceb3f2b
Compare
ceb3f2b
to
cec8361
Compare
Looks good besides picking some more specific naming in the example. |
cec8361
to
c9aa9a3
Compare
c9aa9a3
to
11a9b79
Compare
Closes #286