Implement cxx_qt::inherit! to allow inheriting methods from super class #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
330-inherit-methods
branch
from
c95c10c to
23d0196
Compare
LeonMatthesKDAB
force-pushed
the
330-inherit-methods
branch
2 times, most recently
from
594c00c to
65fbd42
Compare
LeonMatthesKDAB
force-pushed
the
330-inherit-methods
branch
2 times, most recently
from
f0e8d45 to
74c556f
Compare
ahayzen-kdab
reviewed
Dec 8, 2022
ahayzen-kdab
reviewed
Dec 8, 2022
ahayzen-kdab
reviewed
Dec 8, 2022
ahayzen-kdab
reviewed
Dec 8, 2022
Be-ing
reviewed
Dec 9, 2022
LeonMatthesKDAB
force-pushed
the
330-inherit-methods
branch
from
0ac735e to
38e2bd4
Compare
This was referenced Jan 25, 2023
Be-ing
reviewed
Feb 16, 2023
Be-ing
reviewed
Feb 16, 2023
- Explaining comment in qml_features - Improved wording in book Co-authored-by: Be <[email protected]>
- More tests - Extract rust generation into /generator/rust/inherit.rs - Avoid wildcard imports
- Clippy lints - SPDX licenses
Be-ing
reviewed
Feb 22, 2023
Be-ing
reviewed
Feb 22, 2023
Be-ing
reviewed
Feb 22, 2023
Be-ing
reviewed
Feb 22, 2023
Be-ing
reviewed
Feb 22, 2023
Co-authored-by: Be <[email protected]>
Also fix wildcard import
ahayzen-kdab
approved these changes
Feb 23, 2023
przempore
pushed a commit
to przempore/cxx-qt
that referenced
this pull request
Mar 15, 2023
…ss (KDAB#363) * Parse cxx_qt::inherit! into ParsedInheritedMethod * cxx_qt::inherit! - add Rust generation * CombinedIdent: Revert From<Ident> implementation Use associated function `from_rust_function` instead. * cxx_qt::inherit: add rust generation * Allow cxx_qt::inherit on qobjects without base. Base class defaults to `QObject`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation for #330.
Does not include the
friendimplementation for the wrapper method yet, so doesn't complete #330.