Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use React Strict mode #55

Open
toolness opened this issue Aug 24, 2018 · 1 comment
Open

Use React Strict mode #55

toolness opened this issue Aug 24, 2018 · 1 comment

Comments

@toolness
Copy link
Collaborator

I'd like to wrap our app in React Strict mode but it looks like react-router isn't compatible with it right now. Once remix-run/react-router#6060 is fixed and a new version of the router is released, we can enable it.
@toolness
Copy link
Collaborator Author

toolness commented Jun 3, 2019

Hmm, so we upgraded to the latest react-router in #639 but it looks like there are still a few other packages that are violating strict mode: LoadableComponent, Transition, TransitionGroup, and SideEffect(NullComponent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toolness