Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider improving !rp #3327

Closed
8 tasks done
JustArchi opened this issue Nov 2, 2024 · 0 comments
Closed
8 tasks done

Consider improving !rp #3327

JustArchi opened this issue Nov 2, 2024 · 0 comments
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@JustArchi
Copy link
Member

JustArchi commented Nov 2, 2024

Checklist

Enhancement purpose

Right now rp has potential to activate paid items, which should be a supported feature, although explicit.

Solution

We should attempt to fetch current price of the shop item first, and refuse logic if price is more than 0 and user didn't make it explicit to activate paid items. We could make it so each defID accepts ! character like update command, which overrides zero cost.

Why currently available solutions are not sufficient?

Users can accidentally activate paid items when Steam changes them from free to somethin else.

Can you help us with this enhancement idea?

Yes, I can code the solution myself and send a pull request

Additional info

I might be short on time to do it, so PR-ok for the next few weeks in case somebody wants to get down to the implemenetation before I do.

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. ⚪ No priority Issues marked with this label are not being actively worked on for time being. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. and removed 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. ⚪ No priority Issues marked with this label are not being actively worked on for time being. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Development

No branches or pull requests

1 participant