Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the LicenseID #1674

Open
5 tasks done
VasilisThePikachu opened this issue Apr 25, 2024 · 1 comment · May be fixed by #1676
Open
5 tasks done

Hide the LicenseID #1674

VasilisThePikachu opened this issue Apr 25, 2024 · 1 comment · May be fixed by #1676
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request.

Comments

@VasilisThePikachu
Copy link

Checklist

  • I read and understood ASF-ui's Contributing Guidelines
  • I also read FAQ
  • My idea doesn't duplicate existing ASF-ui functionality described on the wiki
  • I believe that my idea falls into ASF-ui's scope and should be offered as part of ASF-ui built-in functionality
  • This is not ASF suggestion

Enhancement purpose

I don't see a reason you would need the licenseid to be visible via ui after you entered it. And should kind of help with not accidently exposing the licenseid

Solution

Just make it hidden!

Why currently available solutions are not sufficient?

Considering, the LicenseID is meant to be kept hidden except of the person who owns the key. It should be hidden. Similar to the bots password and login field

Can you help us with this enhancement idea?

Yes, I can code the solution myself and send a pull request

Additional info

I can try coding this but no promises.
@VasilisThePikachu VasilisThePikachu added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Apr 25, 2024
@MrBurrBurr MrBurrBurr added 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Apr 25, 2024
@Aareksio Aareksio linked a pull request Apr 30, 2024 that will close this issue
Open
5 tasks
@MrBurrBurr
Copy link
Member

MrBurrBurr commented Jun 7, 2024 •
edited
Loading

Ref. JustArchiNET/ArchiSteamFarm@81789c7

LicenseID is not getting exposed anymore, just like the other sensible fields.

@MrBurrBurr MrBurrBurr added the 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. label Jun 7, 2024
@MrBurrBurr MrBurrBurr removed the 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow treating config fields as sensitive JustArchiNET/ASF-ui
2 participants
@MrBurrBurr @VasilisThePikachu