Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASF-ui checks for new release excessively long, if installed ASF version is newer, than latest released #1441

Closed
Botan626 opened this issue Jun 22, 2021 · 4 comments
Closed

ASF-ui checks for new release excessively long, if installed ASF version is newer, than latest released #1441

Botan626 opened this issue Jun 22, 2021 · 4 comments
Labels
🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug.

Comments

@Botan626
Copy link
Contributor

Botan626 commented Jun 22, 2021 •
edited
Loading

Description

This would reduce time for this notification to appear, when user presses Update button, currently it takes more than 15 seconds.
image

ASF shows its warning message immediately after Update button is pressed, while ASF-ui is checking for new version for 15+ seconds.
image

Steps to reproduce

  1. Install ASF of newer version, than latest released,
  2. Press Update button in UI or execute update command,
  3. Count seconds until you see the notification or ASF-ui's respond.
@Botan626 Botan626 added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 22, 2021
@Aareksio
Copy link
Member

@JustArchi POST /api/asf/update seems to take roughly 15 seconds when the current version is ahead of update channel.

image

{"Result":"5.1.0.9","Message":"V5.1.1.1 ≥ V5.1.0.9","Success":false}

@Aareksio Aareksio reopened this Jun 22, 2021
@JustArchi JustArchi mentioned this issue Jun 23, 2021
Closed
@Botan626
Copy link
Contributor Author

This is fixed, I tested it.

@JustArchi JustArchi added 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 28, 2021
@JustArchi
Copy link
Member

Closing as this was on ASF's core side, no point in keeping it up for ASF-ui, not ASF-ui issue to begin with.

@Botan626
Copy link
Contributor Author

not ASF-ui issue to begin with

but it showed itself in ASF-ui

@MrBurrBurr MrBurrBurr added 🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug. and removed 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. labels Jun 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustArchi @Aareksio @Botan626 @MrBurrBurr