Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delimiting comma wrongly appearing outside quotation mark. #232

Open
mccaskey opened this issue Sep 30, 2023 · 3 comments
Open

Delimiting comma wrongly appearing outside quotation mark. #232

mccaskey opened this issue Sep 30, 2023 · 3 comments

Comments

@mccaskey
Copy link

mccaskey commented Sep 30, 2023

In the CSL for Chicago Manual of Style 17th edition (note), change the layout delimiter for <citation> from a semicolon to a comma, that is, change <layout suffix="." delimiter="; "> to <layout suffix="." delimiter=", ">, Select some journal articles. Ensure locale is en-US.

While the delimiting semicolon rightly appeared outside the closing quotation marks, a comma should appear inside. But it doesn’t. We get this citation

Galen, “My own books”, Fumerton, “Logic”, Grafton, “Ancient Works.”

instead of this one

Galen, “My own books,” Fumerton, “Logic,” Grafton, “Ancient Works.”

The suffix period got moved inside, so we know punctuation-in-quote is active,

@mccaskey mccaskey changed the title Comma wrongly appearing outside quotation mark. Delimiting comma wrongly appearing outside quotation mark. Sep 30, 2023
@zepinglee
Copy link
Contributor

The test fixture punctuation_SuppressPrefixPeriodForDelimiterSemicolon.txt reflects this behavior. It seems to be a deliberate design.

@mccaskey
Copy link
Author

mccaskey commented Oct 7, 2023

That test fixture has <citation><layout suffix="." delimiter="; ">.
Change the delimiter to a comma: <citation><layout suffix="." delimiter=", ">.

Doe, “His Anonymous Life”; Roe, “Her Anonymous Life.” should become
Doe, “His Anonymous Life,” Roe, “Her Anonymous Life.” with the comma inside the closing quoteation mark.

@fbennett
Copy link
Contributor

fbennett commented Oct 9, 2023

Somewhere in the code, there is a JS object with parameters for various combinations of punctuation and quotes. There should not be much left to chance on that front. I'll take a look when I get a chance. (If you don't hear back in awhile, feel free to ping. It's been a lethargic or a blue week here, I'm not sure which, but either way I might be slow and you're welcome to prompt and see if it prods me into action.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants