Cameras not discovered

[jterrace]

Description

My C720 and C325WB cameras are not discovered by the dhcp discovery integration. I think it's because they are not listed in the manifest.json.

Reproduction Steps

1. Have a camera not in manifest.json

Expected behavior

Camera is discovered

If applicable, add error logs.

No response

Device Firmware

1.2.2

Integration Version

6.0.1

Using stream component

No

Does camera work via official integrations?

Yes

Camera has all attributes filled out in developer tools

Yes

HASS Environment

Beelink EQ13

Search for similar issues

Yes

Additional information

How did you come up with the large list of models and mac addresses you added to manifest.json? Is there a way to keep it up to date?

Separately, I'm wondering if there might be a better way to do discovery. I found https://github.com/andreikop/python-ws-discovery which does seem to work to find all my tapo cameras, but I can't seem to figure out a way to identify just Tapo cameras. You can identify them by model though, here's my scope list when using wsdiscover:

Discovered:

 address: 192.168.56.109:2020
  - onvif://www.onvif.org/name/C720
  - onvif://www.onvif.org/hardware/C720
  - onvif://www.onvif.org/Profile/Streaming
  - onvif://www.onvif.org/location/Hong Kong
  - onvif://www.onvif.org/type/NetworkVideoTransmitter

 address: 192.168.56.63:2020
  - onvif://www.onvif.org/name/C720
  - onvif://www.onvif.org/hardware/C720
  - onvif://www.onvif.org/Profile/Streaming
  - onvif://www.onvif.org/location/Hong Kong
  - onvif://www.onvif.org/type/NetworkVideoTransmitter

 address: 192.168.56.171:2020
  - onvif://www.onvif.org/name/C720
  - onvif://www.onvif.org/hardware/C720
  - onvif://www.onvif.org/Profile/Streaming
  - onvif://www.onvif.org/location/Hong Kong
  - onvif://www.onvif.org/type/NetworkVideoTransmitter

 address: 192.168.56.127:2020
  - onvif://www.onvif.org/name/C325WB
  - onvif://www.onvif.org/hardware/C325WB
  - onvif://www.onvif.org/Profile/Streaming
  - onvif://www.onvif.org/location/Hong Kong
  - onvif://www.onvif.org/type/NetworkVideoTransmitter

[vyper144]

If that Python WS Discovery works for dynamically finding cameras, what about using character & digit checking?

If "C" (camera) or "D" (doorbell) is the first character AND the second, third, and fourth characters XXX are a number, then very likely it's a Tapo camera.

You could potentially program in a list of off-format devices as well (like TD25).

[jterrace]

The built in ONVIF integration (https://www.home-assistant.io/integrations/onvif/) is actually already using ws-discovery, but it currently has issues because the wsdiscovery library was really old. The author just released a new version though, so hopefully it'll improve things.

If we could just update the list of mac addresses for now, it would be helpful. @JurajNyiri where did you get the list of mac addresses?

[JurajNyiri]

@jterrace it has been some time ago. I remember searching the Mac registry for anything tapo related. Some page like this https://maclookup.app/search/vendors/result?vendor=TP%20Link . I probably searched my device and then searched on vendor for any others.

For mine it returns vendor TP-LINK TECHNOLOGIES CO.,LTD

[JurajNyiri]

If we could gather the starting mac addresses from users here, we would know which ones are tapo and we can add them.

[vyper144]

You just need the first 3 sets of the MAC, right? I have all of those in a spreadsheet for you!

[JurajNyiri]

Feel free to create pr! I will review and merge.