-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eventCode to event input #943
Open
VDubber
wants to merge
4
commits into
main
Choose a base branch
from
add_event_code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−6
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,7 +204,7 @@ export class IntegrationLogger | |
} | ||
|
||
/** | ||
* Answers `true` when the err has been reported to the logger instance | ||
* Answers `true` when the error has been reported to the logger instance | ||
* through these functions: | ||
* | ||
* * warn(err, ...) | ||
|
@@ -376,11 +376,17 @@ export class IntegrationLogger | |
|
||
stepFailure(step: StepMetadata, err: Error) { | ||
const eventName = 'step_failure'; | ||
const { errorId, description } = createErrorEventDescription( | ||
const { errorId, errorCode, description } = createErrorEventDescription( | ||
err, | ||
`Step "${step.name}" failed to complete due to error.`, | ||
); | ||
this.handleFailure({ eventName, errorId, err, description }); | ||
this.handleFailure({ | ||
eventName, | ||
errorId, | ||
eventCode: errorCode, | ||
err, | ||
description, | ||
}); | ||
} | ||
|
||
synchronizationUploadStart(job: SynchronizationJob) { | ||
|
@@ -409,20 +415,27 @@ export class IntegrationLogger | |
|
||
validationFailure(err: Error) { | ||
const eventName = 'validation_failure'; | ||
const { errorId, description } = createErrorEventDescription( | ||
const { errorId, errorCode, description } = createErrorEventDescription( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All we get from the graph projects is an error during the validationFailure phase. We could enhance this but I don't know if it is necessary. Since integrationType + validationFailure is rather unique. |
||
err, | ||
`Error occurred while validating integration configuration.`, | ||
); | ||
this.handleFailure({ eventName, errorId, err, description }); | ||
this.handleFailure({ | ||
eventName, | ||
errorId, | ||
eventCode: errorCode, | ||
err, | ||
description, | ||
}); | ||
} | ||
|
||
private handleFailure(options: { | ||
eventName: 'validation_failure' | 'step_failure'; | ||
errorId: string; | ||
eventCode: string; | ||
err: Error; | ||
description: string; | ||
}) { | ||
const { eventName, errorId, err, description } = options; | ||
const { eventName, errorId, eventCode, err, description } = options; | ||
|
||
// If there is a `code` property on the `Error`, we should include this | ||
// in our log. This is helpful for when we receive an HTTP response error | ||
|
@@ -439,6 +452,7 @@ export class IntegrationLogger | |
this.publishEvent({ | ||
name: eventName, | ||
description, | ||
eventCode, | ||
level: PublishEventLevel.Error, | ||
}); | ||
} | ||
|
@@ -539,6 +553,7 @@ export function createErrorEventDescription( | |
|
||
return { | ||
errorId, | ||
errorCode, | ||
description: `${message} (${errorDetails})`, | ||
}; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add examples to the docstrings?