Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People profiles update logic - if updated on Fireside, how are they scraped or not? #13

Open
gerbrent opened this issue Jul 22, 2022 · 2 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@gerbrent
Copy link
Contributor

I conducted an experiment that led to some questions:

Given a host/guest profile is updated on Fireside..

Currently:

  • the guest's hugo profile is not updated after an explicit scraper launch and hugo rebuild.

Steps to reproduce:

  • change profile on Fireside
  • manually launch scraper workflow via GH Actions
  • manually launch hugo/site CI workflow via GH Actions
  • inspect hugo profile for changes - no change committed

Expected Behaviour

  • since, at present, we are using Fireside as the source-of-truth for episode and people data, the updates to a Fireside profile should be committed to a hugo profile. (this could potentially be destructive..)

Example: Alecks Gates

Typo in his description was fixed on Fireside just now, from The "Offical" Podcasting 2.0 consultant. to The "Official" Podcasting 2.0 consultant. - i.e. Offical -> Official

Hugo profile still contains typo:
"bio": "The \"Offical\" Podcasting 2.0 consultant.",

https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/blob/e061ece2275ce0b3010223ba0be8eba0986e615d/data/people/agates.json#L5

@gerbrent gerbrent added bug Something isn't working question Further information is requested labels Jul 22, 2022
@kbondarev
Copy link
Collaborator

Okay. I’ll modify the scraper to override hosts, guests, and sponsors.
Currently it also overrides the latest episode of each show. Is it safe to assume older shows won’t be modified? Should it maybe override the 3 or even 10 latest episodes of each show? I did see a change recently that after some episode was published the link to the meetup page was modified.

maybe it would be good to run it over all the shows one last time before WordPress shutdown.

@kbondarev
Copy link
Collaborator

Also, what about avatar files? Override them as well or no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants