Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Episode Page - move Sponsors above Episode Links in mobile view #430

Closed
1 task done
gerbrent opened this issue Sep 27, 2022 · 4 comments · Fixed by #557
Closed
1 task done

Episode Page - move Sponsors above Episode Links in mobile view #430

gerbrent opened this issue Sep 27, 2022 · 4 comments · Fixed by #557
Assignees
@CGBassPlayer
Labels
bug Something isn't working design design and visual

Comments

@gerbrent
Copy link
Collaborator

URL

everywhere! ; ) All episode pages in mobile view

On what type of device(s) did you see this bug?

Phone

On which browser(s) are you seeing the problem?

Firefox

Other Browser

Firefox' Responsive Design Mode

Summary

On the Episode pages, it would be preferably to have the Sponsors section above the Episode Links section.

related to #400

image

Contributing
@gerbrent gerbrent added bug Something isn't working design design and visual labels Sep 27, 2022
@gerbrent gerbrent changed the title Episode Page - move sponsors above episode links in mobile view Episode Page - move Sponsors above Episode Links in mobile view Sep 27, 2022
@gerbrent
Copy link
Collaborator Author

@CGBassPlayer I know you were interested in this as a next step to #400. Wanna claim it?

@CGBassPlayer
Copy link
Collaborator

Sure! I'll keep looking into this

On an unrelated note, how was the issue form?

@gerbrent
Copy link
Collaborator Author

gerbrent commented Sep 28, 2022 •
edited
Loading

On an unrelated note, how was the issue form?

good catch!

I'm feeling like us using it it a good test.. so it was fine! I didn't have any issues and the flow was just fine. 💯

@gerbrent gerbrent mentioned this issue Sep 28, 2022
Closed
@CGBassPlayer CGBassPlayer added the in progress currently being worked on label Oct 10, 2022
@CGBassPlayer CGBassPlayer removed the in progress currently being worked on label Jan 22, 2023
@CGBassPlayer
Copy link
Collaborator

Removing in progress tag for now as I have been super busy. I will hopefully get back to this at some point soon

@ChanceM ChanceM mentioned this issue Sep 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CGBassPlayer CGBassPlayer

Labels
bug Something isn't working design design and visual
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mobile: move sponsors, clean padding, condense host/guest list ChanceM/jupiterbroadcasting.com
2 participants
@gerbrent @CGBassPlayer