-
Notifications
You must be signed in to change notification settings - Fork 50
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netlify - Consider for main JB.net deploy previews #173
Comments
I am personally fully supportive of this as I've also used Netlify on my sites. The main reason I'm supportive though is that it would allow me to deploy the serverless function for the live stream endpoint as detailed in #41 |
It could also manage the site hosting and redeploy automatically. |
While yes it could do that, I'd imagine it'd end up costing JB because of how much they'll probably need out of it. So, personally, I'd recommend them just stay with the model they have (GH actions + rsync) and netlify for deploy previews (and serverless functions (if that's possible with our setup)). I think, at least personally I feel this way, just trying to keep as much that JB can host themselves while not being too much of a maintenance burden or expense is the sweet spot for them. |
great thoughts! (also converting to a Discussion) |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
So, one thing that I've normally done in the past is hooked up Netlify to the repo. Normally this is for easy of hosting the NetlifyCMS, but a passive added benefit is using them for deploy previews. This means it'll automatically deploy the changes proposed in a PR for the website. It can be used on the free tier and if layer down the road it breaks or cost money. It'll be easy to remove it, and we'll go back to doing what we're currently doing.
So, this is an example past website that has a deploy preview: Climate-Refugee-Stories/crs-website#95
Then this is the config that's used: https://github.com/Climate-Refugee-Stories/crs-website/blob/master/netlify.toml
It'll take someone on the JB side to hook it up (I'd be willing to hop on a call and work through it with them), but it'd be nice to see peoples change and interact with them instead of relying on people sending screenshots. 😅
There are more advanced features which you'd have to pay for, i.e. a utility overplayed on the website for screenshot'ing + commenting while you're navigating the deploy preview, but just the actual deploy preview feature is free.
We could eventually hook everything up to do deploy previews based on where the changes were coming from but till then just the JB.net works.
The text was updated successfully, but these errors were encountered: