Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed references - point to Fireside feeds #126

Closed
gerbrent opened this issue Jul 19, 2022 · 4 comments · Fixed by #130
Closed

RSS feed references - point to Fireside feeds #126

gerbrent opened this issue Jul 19, 2022 · 4 comments · Fixed by #130
Milestone

Comments

@gerbrent
Copy link
Collaborator

in response to decisions in #108

links to show feeds throughout the site should link to Fireside-appropriate feeds, i.e. the current rss feeds in use via Fireside will persist through the JB.com 1.0 Milestone.

@StefanS-O 's work on custom hugo-generated RSS feeds should be captured somehow for future use if possible.

@gerbrent
Copy link
Collaborator Author

work on custom hugo-generated RSS feeds should be captured somehow for future use if possible.

@elreydetoda Can you discuss a little about how this was thought of and presumably accomplished or not?

@kbondarev
Copy link
Collaborator

I think simplest way is maybe to add some NGINX redirect rules. Something like this:

location  ~ ^show/linux-unplugged/rss$ {
    return 301  https://linuxunplugged.com/rss;
}

@elreydetoda
Copy link
Collaborator

work on custom hugo-generated RSS feeds should be captured somehow for future use if possible.

@elreydetoda Can you discuss a little about how this was thought of and presumably accomplished or not?

So, I left all the code and files that @StefanS-O had created before, and just commented it out. For example:

  • this is the file which Stefan used to generate all the feed
    • I just am telling hugo to not do that type of build anymore, with this line and telling hugo to only build HTML here (not RSS).
  • Then I commented all the code out which referenced the generated RSS file here

So, I addressed it by just commenting everything out. Thank you for asking for more info about it, I love explaining things 😁 and hope it helped. Please let me know if there are any other questions you have about it 🙂

@elreydetoda
Copy link
Collaborator

I think simplest way is maybe to add some NGINX redirect rules. Something like this:

location  ~ ^show/linux-unplugged/rss$ {
    return 301  https://linuxunplugged.com/rss;
}

So, I think that could probably work for if someone does /rss on a show (which would be really cool 😁 IMO), but this issue is for the all shows feed (from my understanding and looking at Stefan's RSS implementation) which is hosted on JB.com now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants