Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suport for Makie Plots [FR] #447

Closed
bradcarman opened this issue Jan 7, 2022 · 1 comment
Closed

Suport for Makie Plots [FR] #447

bradcarman opened this issue Jan 7, 2022 · 1 comment
Labels
enhancement

Comments

@bradcarman
Copy link

I have coded up the necessary parts to Weave Makie plots. Unfortunately I've never done a pull request before, not sure where to start. I can drop the code here, or with some help I can create a proper pull request.

For the most part the code is straight forward, but I do see one potential issue: the capture_output(code, mod, path, error, report) function needs to call display(report, obj) rather than just display(obj). For some reason, if the obj is a Makie.Figure, it get's somehow mangled and converted to a Makie.Scene on the way to calling display(report, obj). Is there any consequence to calling the former rather than the later?
@bradcarman
Copy link
Author

OK, I'm not sure why I thought this was needed, it seems that Makie is working just fine with Weave. I'll go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradcarman