Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not provide the key if it comes from the SSH configuration #648

Closed
wants to merge 1 commit into from
Closed

Do not provide the key if it comes from the SSH configuration #648

wants to merge 1 commit into from

Commits on Jan 13, 2017

  1. Do not provide the key if it comes from the SSH configuration 

    This is a followup of Juniper#628 where this change was initially pushed but
reverted because I didn't remember why I did it. Before Juniper#628, when an
identity is provided in the SSH configuration, it was not copied in
`_conf_ssh_private_key_file` due to a bug. After fixing the bug in Juniper#628,
the key is now copied.

However, the SSH configuration is provided to the `connect()` method
which will use it if needed. Therefore, this is not needed. Moreover, if
the key is provided by an agent and/or encrypted, this won't work as,
later in the code, `allow_agent` will be set to `False` due to the
presence of a private key.
    @vincentbernat
    vincentbernat committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    51a68d1 View commit details
    Browse the repository at this point in the history