-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[port auto-neg] Add yang model for port auto-neg feature #54
Conversation
LGTM, but you need to add the tests, you can use this PR as an example. |
Sure, will update later. |
@vadymhlushko-mlnx could you review again? |
If You add a new leaf in YANG Models: Then please build both: Build tests will make sure, that translation works for new leaves in YANG models. |
Added new field to
|
@vadymhlushko-mlnx could you review again? |
LGTM |
Could you approve it so that I can run a CI? |
Please add me to the "Reviewers" section |
i suppose u can directly review it by clicking "Files Changed"->"Review changes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It should be marked as Yang project PR, and should be discussed once in the yang workgroup. thx. |
[202012][sonic-linkmgrd]Submodule update 8507629 Jing Zhang Mon Apr 4 10:25:22 2022 -0700 Lower unsolicited MUX state change notification log level to WARNING #57 17d217d Longxiang Lyu Mon Mar 21 12:15:19 2022 +0800 Enhance clang format (#46) c72fa2a Jing Zhang Fri Apr 1 12:23:29 2022 -0700 Disable the feature that decreases link probe interval for measuring switch overhead #49 (#54) 256b01b Jing Zhang Thu Mar 31 16:20:00 2022 -0700 Update link prober metrics posting logics #50 #53 dfd48d0 Jing Zhang Wed Mar 23 16:27:45 2022 -0700 Decrease link probing interval after switchover to better determine the overhead of a toggle #43 (#48) sign-off: Jing Zhang [email protected]
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (#55) a1142e251 [sonic_operators.cpp] Update sonic_db_manager::get_counter (#56) 1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (#54) Signed-off-by: Ze Gan <[email protected]>
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (#55) a1142e251 [sonic_operators.cpp] Update sonic_db_manager::get_counter (#56) 1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (#54) Signed-off-by: Ze Gan <[email protected]>
- Why I did it
Add yang model for port auto-neg feature
- How I did it
Add fields adv_speeds, interface_type, adv_interface_types, autoneg
- How to verify it
Run build
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)