Preserve response body when retrying/redirecting #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another iteration in our redirect/retry response body handling. Previously, when the response body is streamed, we ensured only the "final" response body is the one written to the user-provided stream. The only issue is that sometimes it can be helpful to have access to the intermediate response bodies that ended up being retried/redirected. This PR refactors the `readbody` machinery a bit to ensure we always read the response body, and in the case of a user-provided response stream, we read the response body as a string and store it in the request context. One motivation I'm working towards with this is providing more nuanced control over the retry logic, even allowing users to pass in their own `check` function to determine if a request should be retried or not based on the failed response. In that scenario, you'll want access to the failed response body, so this will enabled that.
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
==========================================
+ Coverage 79.97% 80.01% +0.03%
==========================================
Files 36 36
Lines 2867 2867
==========================================
+ Hits 2293 2294 +1
+ Misses 574 573 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another iteration in our redirect/retry response body handling.
Previously, when the response body is streamed, we ensured only the
"final" response body is the one written to the user-provided stream.
The only issue is that sometimes it can be helpful to have access to
the intermediate response bodies that ended up being retried/redirected.
This PR refactors the
readbodymachinery a bit to ensure we always readthe response body, and in the case of a user-provided response stream,
we read the response body as a string and store it in the request context.
One motivation I'm working towards with this is providing more nuanced control
over the retry logic, even allowing users to pass in their own
checkfunctionto determine if a request should be retried or not based on the failed response.
In that scenario, you'll want access to the failed response body, so this will
enabled that.