Fix HTTP.listen with provided TCP server #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sockets.getsockname returns host as an IPAddr and port as Int, but HTTP.Listener expects host and port as Strings.
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
==========================================
+ Coverage 79.78% 79.99% +0.21%
==========================================
Files 36 36
Lines 2849 2849
==========================================
+ Hits 2273 2279 +6
+ Misses 576 570 -6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Pangoraw
added a commit
to fonsp/Pluto.jl
that referenced
this pull request
Jun 19, 2022
Pangoraw
added a commit
to fonsp/Pluto.jl
that referenced
this pull request
Jul 12, 2022
* Update to HTTP.jl 1.0 [HTTP.jl](https://github.com/JuliaWeb/HTTP.jl) is nearing its 1.0 release! This PR is a first draft at updating Pluto to use it. * Use Accept-Encoding: identity in test/compiletimes.jl * use JuliaWeb/HTTP.jl#857 for testing * Allow using IO instead of stream for tests * soften HTTP.jl constraint for now * update HTTP.jl to 1.0.2 * remove test install * close serversocket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sockets.getsockname returns host as an IPAddr and port as Int, but
HTTP.Listener expects host and port as Strings.