Make HTTP.jl exception types more consistent #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed #792. In particular, calling `HTTP.request` will result in one of four possible exceptions: * `HTTP.ConnectError`: something went wrong trying to make a connection to the remote * `HTTP.RequestError`: something went wrong sending/receiving request/response * `HTTP.StatusError`: a 4XX or 5XX response status code was received and status_exception=true * `HTTP.TimeoutError`: the request timed out waiting for a response (if `readtimeout` != 0) Looking over open issues and how downstream repos use HTTP.jl, I found it would be helpful if HTTP.jl indeed had more consistent exception types in place for 1.0 that packages could rely on.
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
+ Coverage 80.95% 81.04% +0.08%
==========================================
Files 35 36 +1
Lines 2757 2754 -3
==========================================
Hits 2232 2232
+ Misses 525 522 -3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #792. In particular, calling
HTTP.requestwill resultin one of four possible exceptions:
HTTP.ConnectError: something went wrong trying to make a connection to the remoteHTTP.RequestError: something went wrong sending/receiving request/responseHTTP.StatusError: a 4XX or 5XX response status code was received and status_exception=trueHTTP.TimeoutError: the request timed out waiting for a response (ifreadtimeout!= 0)Looking over open issues and how downstream repos use HTTP.jl, I found it would be helpful if
HTTP.jl indeed had more consistent exception types in place for 1.0 that packages could rely on.