Auto decompress gzip-encoding response bodies #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements #256. If the content-encoding of a response is "gzip" and the keyword argument `decompress === true`, then we'll use CodecZlib.jl to decompress the response and set as the response body. Passing `decompress=false` will leave the resposne body as-is. We also support `HTTP.decode(::Request, "gzip")` which will do the decompression.
fredrikekre
reviewed
May 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
==========================================
+ Coverage 80.56% 80.80% +0.23%
==========================================
Files 36 36
Lines 2645 2636 -9
==========================================
- Hits 2131 2130 -1
+ Misses 514 506 -8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Awesome, thanks Jacob!! This means that we could add https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Encoding |
|
Great idea! Mind making a PR @fonsp? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #256. If the content-encoding of a response is "gzip"
and the keyword argument
decompress === true, then we'lluse CodecZlib.jl to decompress the response and set as the response
body. Passing
decompress=falsewill leave the resposne body as-is.We also support
HTTP.decode(::Request, "gzip")which will dothe decompression.