Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch ECONNRESET error codes from other platforms #764

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

ashleysommer
Copy link
Contributor

Windows uses -4077
SPAC and ALPHA architectures on linux use -54
Generic architectures on linux uses -104 (this includes x86, x86_64, arm, and arm64)
PARSIC on linux uses -232
MIPS on linux uses -131
I'm guessing MacOS uses -54 too, as this was one code that already worked for a large group of people.
Fixes #763 #547

Windows uses -4077
SPAC and ALPHA on linux use -54
Generic on linux uses -104
PARSIC on linux uses -232
MIPS on linux uses -131
I'm guessing MacOS uses -54 too, as this was one code that already worked for a large group of people.
Fixes JuliaWeb#763 JuliaWeb#547
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #764 (251b595) into master (81ac504) will decrease coverage by 0.78%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   77.59%   76.80%   -0.79%     
==========================================
  Files          38       38              
  Lines        2557     2557              
==========================================
- Hits         1984     1964      -20     
- Misses        573      593      +20     
Impacted Files Coverage Δ
src/Servers.jl 85.97% <0.00%> (ø)
src/HTTP.jl 76.59% <0.00%> (-21.28%) ⬇️
src/WebSockets.jl 85.80% <0.00%> (-4.52%) ⬇️
src/ConnectionPool.jl 80.71% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ac504...251b595. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server emitting errors and traceback on ECONNRESET when it should be a warning.
3 participants