Try all ip addresses when establishing a connection #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/alladdr
branch
2 times, most recently
from
4a57635 to
a1a2a76
Compare
fredrikekre
commented
Feb 19, 2021
test/client.jl
Outdated
Comment on lines
223
to
224
| alladdrs = Sockets.getalladdrinfo("localhost") | ||
| if Sockets.ip"127.0.0.1" in alladdrs && Sockets.ip"::1" in alladdrs |
There was a problem hiding this comment.
This is true on GitHub Actions. Is there a better way of forcing IP adresses that is not the first? Is there an easy way to insert a bad IP for some host?
quinnj
reviewed
Feb 19, 2021
fredrikekre
force-pushed
the
fe/alladdr
branch
from
a1a2a76 to
1a26ed6
Compare
quinnj
approved these changes
Feb 20, 2021
This was referenced Feb 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try all ip addresses when establishing a connection
Fixes #672
Reenables #428