Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: All @info off by default? #378

Closed
EricForgy opened this issue Jan 18, 2019 · 2 comments
Closed

Request: All @info off by default? #378

EricForgy opened this issue Jan 18, 2019 · 2 comments

Comments

@EricForgy
Copy link
Contributor

Here is a question from Slack #gizmos

Another question: Can I mute these:

[ Info: Listening on: Sockets.InetAddr{Sockets.IPv4}(ip"127.0.0.1", 0x11c1)
[ Info: Accept (0):0     0    2s 127.0.0.1:4545:4545 16
[ Info: Accept (1):0     0    0s 127.0.0.1:4545:4545 16
[ Info: Accept (2):0     0    0s 127.0.0.1:4545:4545 16
[ Info: Accept (3):0     0    0s 127.0.0.1:4545:4545 16
[ Info: Accept (4):0     0    0s 127.0.0.1:4545:4545 16 

It may be helpful for you as developers but for me they are just spam.

I kind of agree with that sentiment 😅

Now that HTTP.jl is being used in higher level packages where the users have little (or negative) interest in knowing about connections etc, i.e. they just expect things to work, spewing anything to the REPL feels like spam.

If I understand correctly, this can be handled by replacing

@info blah

with

showinfo && @info blah

or something like that.

What do you think? showinfo should be false by default.

If this is alright, I can go ahead and submit a PR 🙏

@SimonDanisch
Copy link
Contributor

duplicate of #294 ;)

@EricForgy
Copy link
Contributor Author

Ah. Excellent 😊

Will close this one then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants