Hide Authorization header value #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Nov 23, 2023
pfitzseb
reviewed
Nov 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
+ Coverage 82.69% 82.71% +0.01%
==========================================
Files 32 32
Lines 3052 3054 +2
==========================================
+ Hits 2524 2526 +2
Misses 528 528 ☔ View full report in Codecov by Sentry. |
Edits the `show` and `writeheaders` methods to hide the value of Authorization header. This hides the Authorization header when `Request` or `RequestError` objects are `show`n. Fix for JuliaWeb#1125
…eaders like Cookie and Set-Cookie
Co-authored-by: Sebastian Pfitzner <[email protected]>
Co-authored-by: Sebastian Pfitzner <[email protected]>
fredrikekre
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits the
showandwriteheadersmethods to hide the value of Authorization header. This hides the Authorization header value whenRequestorRequestErrorobjects areshown.Fix for #1125