Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse set-cookie expires with trailing GMT #1035

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

gustafsson
Copy link
Contributor

Set-Cookie with the AlternateRFC1123Format (as in expires=Wed, 23-Nov-2011 01:05:03 GMT) works fine.

But I couldn't see any tests for parsing Set-Cookie with Dates.RFC1123Format, i.e without the dashes as in expires=Wed, 23 Nov 2011 01:05:03 GMT.

Dates.RFC1123Format doesn't include the trailing " G\MT" so we need to append that to the format string.

@codecov-commenter
Copy link

Codecov Report

Merging #1035 (11a0d7b) into master (75c1b25) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   85.43%   85.50%   +0.07%     
==========================================
  Files          37       37              
  Lines        3063     3064       +1     
==========================================
+ Hits         2617     2620       +3     
+ Misses        446      444       -2     
Impacted Files Coverage Δ
src/cookies.jl 93.56% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @gustafsson!

@quinnj quinnj merged commit b641baf into JuliaWeb:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants