Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic mlj interface tests #131

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

ablaom
Copy link
Contributor

@ablaom ablaom commented Nov 14, 2024

Adding the tests is not a requirement for MLJ registrtation, but I recommend it. This adds maybe a minute to the test for each platform.

I have also dumped MLJ as a test dep in favour of StatisticalMeasures. Everything except the measures is already provided by MLJBase.

I notice that test/Manifest.toml is committed which seems unusual. I haven't done anything about that.

@pasq-cat
Copy link
Member

@ablaom yeah the manifest is probably my mistake. i may have uploaded it and forgot. @pat-alt i think this can be merged , right?

@pasq-cat
Copy link
Member

i will approve it. let's hope patrick doesn't cross the Alps to kick my butt xD

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.00%. Comparing base (5f66429) to head (7432047).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   97.00%   97.00%           
=======================================
  Files          22       22           
  Lines         734      734           
=======================================
  Hits          712      712           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasq-cat pasq-cat self-requested a review November 14, 2024 20:33
Copy link
Member

@pasq-cat pasq-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure is better than what i wrote

@pasq-cat pasq-cat merged commit d3f0ed5 into JuliaTrustworthyAI:main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants