Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a warning for the case of big shift size #94

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

MojiFarmanbar
Copy link
Member

@pat-alt , I have used @warn to throw a warning to the user. could you please check if using warning macro is the right way?

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Merging #94 (d39c906) into main (3d8dad4) will decrease coverage by 0.55%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   71.99%   71.44%   -0.55%     
==========================================
  Files          20       20              
  Lines         757      760       +3     
==========================================
- Hits          545      543       -2     
- Misses        212      217       +5     
Files Coverage Δ
src/conformal_models/transductive_regression.jl 96.58% <0.00%> (-0.91%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MojiFarmanbar
Copy link
Member Author

I have updated "how to guide" as well. whenever you have time, please check qmd file pls. for some reasons I couldn't test it properly.

@pat-alt
Copy link
Member

pat-alt commented Oct 13, 2023

Hey mate, thanks for this! I have rerendered this now and will merge after tests pass (ignoring nightly).

@pat-alt pat-alt merged commit b20ead0 into JuliaTrustworthyAI:main Oct 13, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants