Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you really need MLJ dependency? #45

Closed
ablaom opened this issue Dec 6, 2022 · 2 comments
Closed

Do you really need MLJ dependency? #45

ablaom opened this issue Dec 6, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ablaom
Copy link

ablaom commented Dec 6, 2022

I notice that CP takes a while to load/precompilel. I'd be surprised if you really need MLJ as a dependency. MLJ essentially just collects these components, and you probably don't need all of them:

  • MLJBase
  • MLJModels (maybe, if you use some then built-in transformers)
  • MLJEnsembles (unlikely)
  • MLJIteration (unlikely)
  • MLJTuning

Ordinary model interfaces just need MLJModelInterface, which is very lightweight. But you will need MLJBase if you are using composite model tools like learning networks, pipelines, etc. And if you are extending measures (but this will ultimately move out). You need it for machines too, but I thought that was factored out now, yes?

@pat-alt
Copy link
Member

pat-alt commented Dec 7, 2022

Thanks for flagging this @ablaom, good point! And you're right, we don't need all of MLJ. In fact, we can probably do with just MMI.

The only thing (outside of measures) we currently rely on MLJBase for is cross-validation, e.g. here. It might be wiser to just implement CV from scratch, what do you think? Edit: Precompile is still very slow 😞

Have now removed MLJ as a dependency in b7c8b1b and will close once that's merged into main.

Thanks again!

@pat-alt pat-alt added the enhancement New feature or request label Dec 7, 2022
@ablaom
Copy link
Author

ablaom commented Dec 8, 2022

Resampling (eg, CV) is something else we've thought of moving out to a separate repo, so maybe leave the MLJBase dep for now.

@pat-alt pat-alt closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants