Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort ambiguities and type piracies by function name #233

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

lgoettgens
Copy link
Collaborator

Resolves #226.

Sorts both the reported ambiguities and type piracies by function name for easier fixing.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #233 (0237d1e) into master (de25cfa) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   88.33%   88.40%   +0.06%     
==========================================
  Files          10       10              
  Lines         506      509       +3     
==========================================
+ Hits          447      450       +3     
  Misses         59       59              
Flag Coverage Δ
unittests 88.40% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/ambiguities.jl 91.47% <100.00%> (+0.06%) ⬆️
src/piracies.jl 94.18% <100.00%> (+0.13%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@lgoettgens lgoettgens merged commit 0979329 into JuliaTesting:master Nov 4, 2023
19 of 20 checks passed
@lgoettgens lgoettgens deleted the lg/ambiguity-sort branch November 4, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: group ambiguities by function
2 participants