-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Piracy detection by considering more methods #156
Enhance Piracy detection by considering more methods #156
Conversation
97b11ee
to
1c6cf69
Compare
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 77.07% 67.13% -9.94%
==========================================
Files 11 11
Lines 724 569 -155
==========================================
- Hits 558 382 -176
- Misses 166 187 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ping @fingolfin |
ebc2dc0
to
8dbb2f5
Compare
8dbb2f5
to
9ae3c19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what this does exactly but I trust you thought this through.
Resolves #155 and resolves #157.
The main change is a re-implementation of
all_methods
. Unfortunately, the old data sourcenames(MyModule)
was missing some callables (#157) and methods of non-imported functions that have been defined in a fully qualified way (#155). The proposed implementation works very similarly toTest.detect_ambiguities
andTest.detect_unbound_args
by iterating over allnames
of all currently loaded modules, and then filtering out the methods that are indeed defined inMyModule
.I furthermore added some tests displaying the new functionality. The main point here is that
Aqua.jl/test/test_piracy.jl
Lines 58 to 62 in 94a9c7a
is no longer needed.