Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test_ambiguities #144

Merged
merged 4 commits into from
Jun 25, 2023
Merged

Conversation

lgoettgens
Copy link
Collaborator

As written in the removed comment, test_ambiguities does not allow non-singleton callable in exclude. This is working now.
I furthermore changed the behavior for singleton callables to be the same. And I introduced constructors for exclude.
Unfortunately, one can only exclude the constructor of type MyType and all callables of MyType simultaneously, or none of both.

For my convenience, this already includes the changes of #143.

This change is probably breaking, semi-documented behavior of exclude for test_ambiguities. I thus bumped the version.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #144 (a38c5e1) into master (c7eb4d4) will decrease coverage by 0.08%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   77.14%   77.07%   -0.08%     
==========================================
  Files          11       11              
  Lines         722      724       +2     
==========================================
+ Hits          557      558       +1     
- Misses        165      166       +1     
Flag Coverage Δ
unittests 77.07% <83.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ambiguities.jl 89.60% <83.33%> (-0.65%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgoettgens lgoettgens marked this pull request as draft June 21, 2023 13:14
@fingolfin
Copy link
Member

Needs a rebase

@lgoettgens lgoettgens marked this pull request as ready for review June 25, 2023 14:56
@fingolfin fingolfin merged commit f4c3352 into JuliaTesting:master Jun 25, 2023
@lgoettgens lgoettgens deleted the lg/ambiguities-2 branch June 25, 2023 20:20
lgoettgens added a commit to lgoettgens/Aqua.jl that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants