Fix getobj
for parameterized callable objects
#142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49 and fixes #141.
The main change is the unwrapping of
UnionAll
s ingetobj
. While looking through it, I furthermore used it in the piracy tests as well (where until now the function was basically inlined). And ingetobj
the deprecated functiontuple_type_head
was used, the alternative isfieldtype(-, 1)
. Both changes have been tested in julia 1.0, 1.6 and 1.9.The MWE in #49 (comment) by @mtsch for julia 1.0 (
Aqua.test_ambiguities([MWE, Base, Core], exclude=[convert])
) reports precisely the same 52 ambiguities (up to order) as with the current master, but there are no errors.The much smaller MWE in #49 (comment) by @fingolfin for julia 1.9 no longer fails.
Please check if this fixes it for you as well.