Fix some incorrect piracy flagging #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 75.17% 75.34% +0.17%
==========================================
Files 11 11
Lines 705 718 +13
==========================================
+ Hits 530 541 +11
- Misses 175 177 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If the type of a method *argument* is a union, then if *any* of the types in the union is foreign, the whole type should count as foreign. But when installing a method for a union, then it should only count as foreign if *all* the types in the union are foreign.
fingolfin
force-pushed
the
mh/piracy-reporting
branch
from
169b8c0 to
1079abf
Compare
lgoettgens
reviewed
Jun 21, 2023
Comment on lines
+154
to
156
| is_foreign_method(signature.parameters[1], method_pkg) || return false | ||
|
|
||
| all(param -> is_foreign(param, method_pkg), signature.parameters) |
There was a problem hiding this comment.
As the first entry of signature.parameters is handled differently, the is_foreign check should only be applied to signature.parameters[2:end], right?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type of a method argument is a union, then if any of the types in the union is foreign, the whole type should count as foreign.
But when installing a method for a union, then it should only count as foreign if all the types in the union are foreign.
Resolves #114