Improve error message on unbound args #103
Conversation
Explain how seemingly well define typevars can result in unbound args in the presence of Vararg, and also display the offending methods in a more readable way. See JuliaTesting#87
|
the PR looks good to me, but I'm not sure who has merge rights now, given @tkf seems not active on GitHub anymore... |
|
@DilumAluthge made a release last week, so at the very least he seems to have commit rights. But I am not sure if he also is interested in maintaining the package overall (or if anyone is). |
src/unbound_args.jl
Outdated
| append!(methods, detect_unbound_args(x)) | ||
| # This was fixed some time between 1.4.2 and 1.6.7 | ||
| # https://github.com/JuliaLang/julia/pull/31972 | ||
| @static if VERSION < v"1.6.7" |
There was a problem hiding this comment.
Just so I understand: this part of the patch is unrelated to the actual subject of the PR, right? It just disables an old workaround for newer Julia versions, yes?
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 75.00% 75.25% +0.25%
==========================================
Files 11 11
Lines 676 691 +15
==========================================
+ Hits 507 520 +13
- Misses 169 171 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks! |
Explain how seemingly well define typevars can result in unbound args in the presence of Vararg, and also display the offending methods in a more readable way.
Closes #87