From ac007e1bd02834195b3a8491a2a5473274e83d3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= Date: Tue, 17 Oct 2023 15:14:53 +0200 Subject: [PATCH] Fix test --- test/test_deps_compat.jl | 22 ++++++++++++++-------- test/test_smoke.jl | 1 + 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/test/test_deps_compat.jl b/test/test_deps_compat.jl index fe3dd2b1..acb8558c 100644 --- a/test/test_deps_compat.jl +++ b/test/test_deps_compat.jl @@ -12,14 +12,6 @@ const DictSA = Dict{String,Any} "deps", ) @test isempty(result) - result = find_missing_deps_compat( - DictSA( - "deps" => DictSA("SHA" => "ea8e919c-243c-51af-8825-aaa63cd721ce"), - "compat" => DictSA("julia" => "1"), - ), - "deps", - ) - @test isempty(result) result = find_missing_deps_compat( DictSA( "deps" => DictSA("PkgA" => "229717a1-0d13-4dfb-ba8f-049672e31205"), @@ -69,6 +61,20 @@ const DictSA = Dict{String,Any} @test length(result) == 1 @test [pkg.name for pkg in result] == ["PkgB"] end + + @testset "does not specify `compat` for stdlib" begin + result = find_missing_deps_compat( + DictSA( + "deps" => DictSA( + "LinearAlgebra" => "37e2e46d-f89d-539d-b4ee-838fcccc9c8e", + ), + "compat" => DictSA("julia" => "1"), + ), + "deps", + ) + @test length(result) == 1 + @test [pkg.name for pkg in result] == ["LinearAlgebra"] + end end end diff --git a/test/test_smoke.jl b/test/test_smoke.jl index 669341a3..f493e903 100644 --- a/test/test_smoke.jl +++ b/test/test_smoke.jl @@ -6,6 +6,7 @@ using Aqua Aqua.test_all( Aqua; stale_deps = (; ignore = [:Compat]), # conditionally loaded + deps_compat = VERSION <= v"1.3-" ? (; ignore = [:Test]) : true, ) # test everything else