Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Use target_compile_definitions to avoid affecting global definitions #121

Merged

Conversation

past-due
Copy link
Contributor

@past-due past-due commented Apr 5, 2018

utf8proc's use of add_definitions affects the global definitions.

Instead, use target_compile_definitions.

@stevengj stevengj merged commit fe3f6bd into JuliaStrings:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants