Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes docs on dotfile #532

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Removes docs on dotfile #532

merged 1 commit into from
Jan 21, 2025

Conversation

ValentinKaisermayer
Copy link
Contributor

Closes #531

@ValentinKaisermayer
Copy link
Contributor Author

@iblislin

@iblislin
Copy link
Collaborator

well, I think we should add some deprecate warning first.
Then, scheduling for removal.

Maybe add a banner in Documenter:
https://documenter.juliadocs.org/stable/showcase/#Warning-admonition

@ValentinKaisermayer
Copy link
Contributor Author

I don't think so. The breaking change has already happened with v0.24, so this is more like a patch.

@iblislin
Copy link
Collaborator

ah, ok.

could you rebase this PR?

@ValentinKaisermayer
Copy link
Contributor Author

I rebased it

@iblislin iblislin merged commit b1addf8 into JuliaStats:master Jan 21, 2025
5 checks passed
@ValentinKaisermayer ValentinKaisermayer deleted the vk-rm-dotfile-docs branch January 21, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove doc section about customized printing
2 participants
@ValentinKaisermayer @iblislin