Codecov: set fail_ci_if_error to false iff the PR is made from a fork
#920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devmotion What do you think of this approach? |
|
I think this might be useful given the current instability of codecov. I'd like to avoid surprising coverage drops in PRs from forks though - maybe if someone with admin permission additionally makes codecov a mandatory check, this would not be possible? On the other hand, of course, this would require that at least one of the codecov uploads succeeds. |
|
You could set up GitHub Merge Queue on this repo, and then make Codecov a required status check. The GitHub Merge Queue jobs ( |
|
Hasn't the Codecov action stabilized so much at this point that it's not worth adding extra complexity to our script? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.