-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distributed and reduced precision bootstrap #694
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 95.64% 95.68% +0.04%
==========================================
Files 35 35
Lines 3190 3225 +35
==========================================
+ Hits 3051 3086 +35
Misses 139 139
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The example of changing |
@palday Is there anything in particular that you would like me to concentrate on when reviewing this PR? |
@dmbates whether the general reduced precision approach is valid statistically. |
@palday Sorry for making commits to your branch rather than creating suggestions. I used to know how to create a suggestion that would just require you to click on a button to accept it but I can't seem to work out how to do that now. After flailing around for far too long, I eventually just made the commits. |
Regarding the validity of allowing more slack in |
The check on the nightly version failed to compile some of the dependencies of BSplineKit.jl I saw that on a locally compiled nightly too and I don't think we will need to take action on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I think the optsum_overrides
will be very useful.
@dmbates Exactly my thoughts! I just wanted a sanity check. Thanks for the other edits. 😄 |
The idea for the reduced precision bootstrap came out of my work looking at the optimizer/convergence behavior.
docs/NEWS-update.jl
to update the cross-references.