Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypedTables as a dependency to make it easier to return tables from simulations? #631

Closed
dmbates opened this issue Jul 30, 2022 · 1 comment

Comments

@dmbates
Copy link
Collaborator

dmbates commented Jul 30, 2022

At present the allpars property of a parametric bootstrap sample is usually converted immediately to a DataFrame for manipulation. We probably don't want to have MixedModels.jl depend on DataFrames.jl but should we consider a dependency on TypedTables.jl? It is a much lighter weight package than DataFrames.jl and could suffice for most of our uses.

@palday
Copy link
Member

palday commented Aug 1, 2022

I'm not opposed to this, but it may be "lightly breaking" if any consumers are expected a concrete type instead of just a column table. That shouldn't hold us back from doing this in a minor release though as long as we're very clear in the release notes. We might also want to update the docstrings that we make guarantees about not breaking the table schema, but not necessarily about the concrete type.

Also, if this is mostly about displaying the bootstrap results -- should we add a show method to MixedModelsBootstrap that does a pretty printed allpars by default?

@palday palday closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants