-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of constant response #578
Conversation
For GLMM, this means allow constructing a model with a constant response. This is useful for simulation. For both GLMM and LMM, catch an initial PosDefException. If the PosDefException is from a constant response, throw ArgumentError.
b5a7928
to
17b5516
Compare
Codecov Report
@@ Coverage Diff @@
## main #578 +/- ##
==========================================
- Coverage 96.25% 96.22% -0.03%
==========================================
Files 28 28
Lines 2509 2516 +7
==========================================
+ Hits 2415 2421 +6
- Misses 94 95 +1
Continue to review full report at Codecov.
|
The drop in coverage is from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for doing this.
Well, except for that test error thing.
@dmbates Yeah, it looks like subtle linear algebra differences lead to GLMM failing at an unexpected point for GLMM, so I've just moved to always testing for constant response in |
(The test should still be faster than trying to add error trapping into the objective evaluation.) |
For GLMM, this means allow constructing a model with a constant response.
This is useful for simulation.
For both GLMM and LMM, catch an initial PosDefException.
If the PosDefException is from a constant response, throw ArgumentError.
Technically this is a "feature" so I've done a minor version bump instead of patch.