Support for bootstrapping models with a mixture of correlation structures #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the type constraint on λ fixes problems when bootstrapping models with a mixture of zerocorr (Diagonal) and non zerocorr (LowerTriangular) RE representations. We also remove the type constraint on the parent, i.e. internal storage within LowerTriangular|Diagonal so that we can better support more types in the future. As a pleasant side effect, this makes the type parameterization easier.
Codecov Report
@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 28 28
Lines 2509 2509
=======================================
Hits 2415 2415
Misses 94 94
Continue to review full report at Codecov.
|
kleinschmidt
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the type constraint on
MixedModelsBootstrap.λto allow bootstrapping models with a mixture of correlation structures, e.g. somezerocorrand some nonzerocorrrandom effects.