Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mime show for RE without FE #501

Merged
merged 2 commits into from
Apr 9, 2021
Merged

update mime show for RE without FE #501

merged 2 commits into from
Apr 9, 2021

Conversation

palday
Copy link
Member

@palday palday commented Apr 9, 2021

These models are well defined so we should show them correctly.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #501 (8082c89) into main (624805c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 8082c89 differs from pull request most recent head ec01718. Consider uploading reports for the commit ec01718 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   93.96%   93.98%   +0.02%     
==========================================
  Files          26       26              
  Lines        2153     2162       +9     
==========================================
+ Hits         2023     2032       +9     
  Misses        130      130
Impacted Files Coverage Δ
src/mimeshow.jl 98.60% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624805c...ec01718. Read the comment docs.

@palday palday requested a review from dmbates April 9, 2021 10:04
dmbates
dmbates approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@palday palday merged commit 7b6dd31 into main Apr 9, 2021
@palday palday deleted the pa/mdshow branch April 9, 2021 18:05
palday added a commit that referenced this pull request Apr 9, 2021
@palday
update mime show for RE without FE (#501)
00b6329 
* update mime show for RE without FE

* NEWS entry
(cherry picked from commit 7b6dd31)
palday added a commit that referenced this pull request Apr 9, 2021
@palday
BACKPORT: mimeshow RE without FE (#502)
efe8ec2 
* update mime show for RE without FE (#501)
(cherry picked from commit 7b6dd31)

* patch bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbates dmbates dmbates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palday @dmbates