Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize constructors #449

Merged
merged 7 commits into from
Dec 9, 2020
Merged

Modularize constructors #449

merged 7 commits into from
Dec 9, 2020

Conversation

palday
Copy link
Member

@palday palday commented Dec 9, 2020

This splits our main (non default) constructor into several stages. The idea is that packages like unfold.jl that do a lot of the model matrix construction can still take advantage of the rest of our machinery and not duplicate effort in a brittle way.

@behinger

@palday
Copy link
Member Author

palday commented Dec 9, 2020

I think this should be a patch release because these changes are officially marked as being "internal", even those some of our collaborators are going to use these internal changes as a versioning requirement.

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #449 (cb755e3) into master (f0caa2b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   92.85%   92.86%           
=======================================
  Files          23       23           
  Lines        1736     1738    +2     
=======================================
+ Hits         1612     1614    +2     
  Misses        124      124           
Impacted Files Coverage Δ
src/linearmixedmodel.jl 94.26% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0caa2b...cb755e3. Read the comment docs.

@palday palday requested a review from dmbates December 9, 2020 16:47
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@palday palday merged commit 92d2e1b into master Dec 9, 2020
@palday palday deleted the pa/mat_constructor branch December 9, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants