Drop dependency on NamedArrays package #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 94.99% 95.30% +0.31%
==========================================
Files 23 23
Lines 1617 1575 -42
==========================================
- Hits 1536 1501 -35
+ Misses 81 74 -7
Continue to review full report at Codecov.
|
palday
approved these changes
Sep 28, 2020
| @@ -15,7 +15,7 @@ Tables.Schema: | |||
| :σ T | |||
| :β NamedTuple{β_names}{NTuple{p,T}} | |||
| :se StaticArrays.SArray{Tuple{p},T,1,p} | |||
| :θ StaticArrays.SArray{Tuple{p},T,1,k} | |||
| :θ StaticArrays.SArray{Tuple{k},T,1,k} | |||
There was a problem hiding this comment.
This was a copy-paste error I introduced, right?
There was a problem hiding this comment.
Yes.
Sorry for putting that in this PR without explanation. I was trying to decide if the StaticArrays package was still needed and found this while doing a search on the name.
|
I'm happy to squash and merge when you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namedargument toranefand the dependency on theNamedArrayspackage that it requiredraneftablesfunction provides an alternative that, in most cases, is easier to work with.