Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields of struct are treated as globals #9

Open
tkf opened this issue Nov 1, 2019 · 2 comments
Open

Fields of struct are treated as globals #9

tkf opened this issue Nov 1, 2019 · 2 comments

Comments

@tkf
Copy link
Contributor

tkf commented Nov 1, 2019

Hi, thanks for a super useful package. Unfortunately, I think I find a bug

julia> solve(:(struct S
           x
       end))
:(struct @global S
      #= REPL[11]:2 =#
      @global x
  end)

I suppose @global x is wrong?

@thautwarm
Copy link
Member

Yes, I didn't treat struct yet.
A bit curious, Is this necessary? I think the scope of struct is simple so we can treat them separately.

@tkf
Copy link
Contributor Author

tkf commented Nov 1, 2019

Yeah, I think I can skip fields while processing solved tree. But I thought it would be nice if I can just blindly look for ScopedVar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants