Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ldiv! overload on sparse QR #242

Open
ChrisRackauckas opened this issue Sep 1, 2022 · 6 comments
Open

Missing ldiv! overload on sparse QR #242

ChrisRackauckas opened this issue Sep 1, 2022 · 6 comments

Comments

@ChrisRackauckas
Copy link

using SparseArrays, LinearAlgebra
A = rand(4,4)
S = sprand(4,4,0.1)
b = rand(4)
Aqr = qr(A)
Sqr = qr(S)
Aqr \ b # works!
Sqr \ b # works!
ldiv!(x, Aqr, b) # works!
ldiv!(x, Sqr, b) # fails!!!!!!!!!!!!!
@SobhanMP
Copy link
Member

SobhanMP commented Sep 1, 2022

is this even supported in SPQR? i couldn't find anything in the user doc

@rayegun
Copy link
Member

rayegun commented Sep 4, 2022

I will have to dig deeper into what SPQR is doing, I'm only really familiar with the UMFPACK and KLU code.

@rayegun
Copy link
Member

rayegun commented Oct 8, 2022

SPQR does not support ldiv! natively. What do you want ldiv! to do @ChrisRackauckas? We can define a copying form, that copies to x.

@ViralBShah
Copy link
Member

It should just give an error saying that the operation is not available, since you can't t do these things in-place.

@rayegun
Copy link
Member

rayegun commented Oct 8, 2022

There's a MethodError now, do you think it should be more specific?

@ViralBShah
Copy link
Member

Yes, I think an error message might make sense, since MethodError makes people think it is an unimplemented case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants