Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Octogonapus, do you happen to know what we need to tweak in the generated bindings to get these examples to work? To spell out the problem as clearly as possible:
resolver_options = aws_host_resolver_default_options(8, el_group, C_NULL, C_NULL)
host_resolver = aws_host_resolver_new_default(allocator, resolver_options)
But getting an unsafe_convert error because an instance of
aws_host_resolver_default_options
can't be convert toPtr{aws_host_resolver_default_options}
. The correct ccall pattern here is to specify the struct pointer type asRef{aws_host_resolver_default_options}
and this fixes my usage.If you happen to know what we need to tweak in the bindings generation, I can make the changes, just wanted to check since you know the generation process much better than I do.