Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ArrayInterfaceCore dependency #511

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Oct 5, 2023

ArrayInterface 7.x, which is already required, switched to using package extensions and removed the ArrayInterfaceCore package.
Get rid of that dependency and use the symbols directly from ArrayInterface instead.

(These two symbols are just aliases of types from other packages which is why this still works right now.)

ArrayInterface 7.x, which is already required, switched to using package extensions
and removed the ArrayInterfaceCore package.
Get rid of that dependency and use the symbols directly from ArrayInterface instead.

(These two symbols are just aliases of types from other packages which is why
this still works right now.)
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (537496a) 86.99% compared to head (b91b29c) 88.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   86.99%   88.76%   +1.76%     
==========================================
  Files          39       39              
  Lines        9596     9600       +4     
==========================================
+ Hits         8348     8521     +173     
+ Misses       1248     1079     -169     
Files Coverage Δ
src/LoopVectorization.jl 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chriselrod chriselrod merged commit 046c312 into JuliaSIMD:main Nov 2, 2023
48 of 59 checks passed
@yuyichao yuyichao deleted the remove-array-core branch November 2, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants